Fix Ordering of Templates Within Create Plan Template Dropdown #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, all of the templates were simply being sorted by title. Now, the sorting follows the instructions specified within the following GitHub issue comment: #685 (comment)
The `funder.present? && !funder.new_record?` check was being unnecessarily repeated. NOTE: This file features a lot of code exclusive to DMP Assistant. I feel like it could be further cleaned up.
aaronskiba
force-pushed
the
aaron/issues/685
branch
from
d0f3ffb to
d3da6de
Compare
Commit d127444 removed this assignment. However, considering that this instance variable may be used by some corresponding views, this commit puts back the assignment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #685
Changes proposed in this PR: