Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Validation Check to Enable Updates Of All Existing DMP Assistant Orgs #595

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

aaronskiba
Copy link
Collaborator

Fixes #587

Changes proposed in this PR:

  • Can't Update Some Fields Due To case_insensitive Validation #587
  • DMP Assistant's production db currently includes some org names that would not pass the uniqueness validation check with the previous case_sensitive: false statement.
  • This change can be reverted when the affected Org names are addressed (this PR also includes a code comment pointing this out).

DMP Assistant's production db currently includes some org names that will not pass the uniqueness validation check when case_sensitive is set to false.
.case_insensitive must be removed from tests to correspond with the change made in commit b099a40.
Copy link
Collaborator

@200455939-yashu 200455939-yashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 🥳

@aaronskiba aaronskiba merged commit e778538 into deployment-portage Jan 11, 2024
12 checks passed
@aaronskiba aaronskiba deleted the aaron/issues/587 branch January 11, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't Update Some Fields Due To case_insensitive Validation
2 participants