Color Rebranding with Digital Grey and Yellow #trivial #421
Conversation
Generated by 🚫 Danger |
200455939-yashu
changed the title
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
There was a problem hiding this comment.
I'm wondering about the various .png and .svg files with respect to GB:
- For all of the en-CA, en_CA, fr-CA, and fr_CA files, there is a .png as well as a corresponding .svg file. Should we also have
app/assets/images/dmp_logo_en-GB.svgandapp/assets/images/dmp_logo_en_GB.svg? (Or maybe we don't need the GB files at all?)
There was a problem hiding this comment.
We need the British English logo, but currently lack the SVG files. @lagoan, Please assist!
There was a problem hiding this comment.
You mention the formatting of this stylesheet into multiple stylesheets. Not sure if we should handle this now or later @lagoan? If later, maybe just make a GitHub issue for it in the meantime.
Also, there is just one comment typo Drop downs of the coloege lists in create plans section that is a bit difficult to decipher.
There was a problem hiding this comment.
About the formatting the stylesheet this will be easier to track the changes as well as it will easier to add or modify these changes.
@lagoan please guide us.
There was a problem hiding this comment.
A branding page exists on the DMPRoadmap wiki, and includes a recommended approach for stylesheet customizations: https://github.com/DMPRoadmap/roadmap/wiki/Branding#stylesheets
Maybe this is the best way to refactor, @lagoan?
Fixes # .
Changes proposed in this PR: The Rebranding changes related to the color are added
#331