Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

found github action ruby 'version not valid' issue in the development process #265

Closed
Tracked by #264
pengyin-shan opened this issue Nov 22, 2022 · 1 comment
Closed
Tracked by #264

found github action ruby 'version not valid' issue in the development process #265

pengyin-shan opened this issue Nov 22, 2022 · 1 comment
Assignees
@pengyin-shan

Comments

@pengyin-shan
Copy link

pengyin-shan commented Nov 22, 2022 •
edited
Loading

Refer to https://github.com/ruby/setup-ruby.

Noticed the following complaint suddenly appears for GitHub actions that need the ruby version defined:

Screenshot 2022-11-22 at 2 31 49 PM

After the test, seems a single quote is necessary now for version validation (i.e ruby-version: '2.7.6' instead of ruby-version: 2.7.6.

Will investigate.
@pengyin-shan pengyin-shan mentioned this issue Nov 22, 2022
Closed
3 tasks
@pengyin-shan pengyin-shan self-assigned this Nov 22, 2022
pengyin-shan added a commit that referenced this issue Nov 22, 2022
@pengyin-shan
fix #265
78b161a
pengyin-shan added a commit that referenced this issue Nov 22, 2022
@pengyin-shan
test fixing #265 by upgrading to checkout@v3 and ruby@v1
3466fda
@pengyin-shan
Copy link
Author

As a note, the problem show be fixed in commit 3466fda.

Closet this ticket since it is part of 3.1.0_rubocop_only branch. The PR for #264 will include this fix

@pengyin-shan pengyin-shan mentioned this issue Nov 28, 2022
Merged
This was referenced Dec 14, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pengyin-shan pengyin-shan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pengyin-shan