discovered issue running specs on mysql. new version of mysqld consid…

…ers uniqueness to be case sensitive, so added case insensitivity flag to models and specs. Also added indexes for these

app/models/department.rb

@@ -30,7 +30,7 @@ class Department < ApplicationRecord
 
   validates :name, presence: { message: PRESENCE_MESSAGE },
                    uniqueness: { message: UNIQUENESS_MESSAGE,
-                                 scope: :org_id }
+                                 scope: :org_id, case_sensitive: false }
 
   validates :name, uniqueness: { message: UNIQUENESS_MESSAGE,
                                  scope: :org_id }

app/models/org.rb

@@ -93,7 +93,8 @@ class Org < ApplicationRecord
   # ===============
 
   validates :name, presence: { message: PRESENCE_MESSAGE },
-                   uniqueness: { message: UNIQUENESS_MESSAGE }
+                   uniqueness: { message: UNIQUENESS_MESSAGE,
+                                 case_sensitive: false }
 
   validates :is_other, inclusion: { in: BOOLEAN_VALUES,
                                     message: PRESENCE_MESSAGE }

app/models/perm.rb

@@ -35,7 +35,8 @@ def lazy_load(name)
   # ===============
 
   validates :name, presence: { message: PRESENCE_MESSAGE },
-                   uniqueness: { message: UNIQUENESS_MESSAGE }
+                   uniqueness: { message: UNIQUENESS_MESSAGE,
+                                 case_sensitive: false }
 
   # =================
   # = Class methods =

app/models/question_format.rb

@@ -41,7 +41,8 @@ class QuestionFormat < ApplicationRecord
   # ===============
 
   validates :title, presence: { message: PRESENCE_MESSAGE },
-                    uniqueness: { message: UNIQUENESS_MESSAGE }
+                    uniqueness: { message: UNIQUENESS_MESSAGE,
+                                  case_sensitive: false }
 
   validates :description, presence: { message: PRESENCE_MESSAGE }
 

app/models/region.rb

@@ -27,7 +27,8 @@ class Region < ApplicationRecord
   # ===============
 
   validates :name, presence: { message: PRESENCE_MESSAGE },
-                   uniqueness: { message: UNIQUENESS_MESSAGE }
+                   uniqueness: { message: UNIQUENESS_MESSAGE,
+                                 case_sensitive: false }
 
   validates :description, presence: true
 

db/migrate/20220614181654_add_uniqueness_indexes.rb

@@ -0,0 +1,9 @@
+class AddUniquenessIndexes < ActiveRecord::Migration[6.1]
+  def change
+    add_index :departments, %i[name org_id], unique: true
+    add_index :orgs, :name, unique: true
+    add_index :perms, :name, unique: true
+    add_index :question_formats, :title, unique: true
+    add_index :regions, :abbreviation, unique: true
+  end
+end

db/schema.rb

@@ -102,6 +102,7 @@
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
     t.index ["org_id"], name: "index_departments_on_org_id"
+    t.index ["name", "org_id"], name: "index_departments_on_name_org_id"
   end
 
   create_table "exported_plans", id: :integer, force: :cascade do |t|
@@ -275,13 +276,15 @@
     t.text "api_create_plan_email_body"
     t.index ["language_id"], name: "fk_rails_5640112cab"
     t.index ["region_id"], name: "fk_rails_5a6adf6bab"
+    t.index ["name"], name: "index_orgs_on_name"
     t.string "helpdesk_email"
   end
 
   create_table "perms", id: :integer, force: :cascade do |t|
     t.string "name"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
+    t.index ["name"], name: "index_perms_on_names"
   end
 
   create_table "phases", id: :integer, force: :cascade do |t|
@@ -355,6 +358,7 @@
     t.datetime "updated_at", null: false
     t.boolean "option_based", default: false
     t.integer "formattype", default: 0
+    t.index ["title"], name: "index_perms_on_titles"
   end
 
   create_table "question_options", id: :integer, force: :cascade do |t|
@@ -396,6 +400,7 @@
     t.string "description"
     t.string "name"
     t.integer "super_region_id"
+    t.index ["abbreviation"], name: "index_regions_on_abbreviations"
   end
 
   create_table "related_identifiers", force: :cascade do |t|

spec/models/department_spec.rb

@@ -15,6 +15,7 @@
       subject = create(:department, org_id: org.id)
       expect(subject).to validate_uniqueness_of(:name)
         .scoped_to(:org_id)
+        .case_insensitive
         .with_message('must be unique')
     end
   end

spec/models/org_spec.rb

@@ -8,7 +8,8 @@
 
     it {
       subject.name = 'DMP Company'
-      is_expected.to validate_uniqueness_of(:name).with_message('must be unique')
+      is_expected.to validate_uniqueness_of(:name).case_insensitive
+                                                  .with_message('must be unique')
     }
 
     it { is_expected.to allow_values(true, false).for(:is_other) }

spec/models/perm_spec.rb

@@ -24,7 +24,8 @@ def recreate_all
     it { is_expected.to validate_presence_of(:name) }
 
     it {
-      is_expected.to validate_uniqueness_of(:name).with_message('must be unique')
+      is_expected.to validate_uniqueness_of(:name).case_insensitive
+                                                  .with_message('must be unique')
     }
   end
 

spec/models/question_format_spec.rb

@@ -7,7 +7,8 @@
     it { is_expected.to validate_presence_of(:title) }
 
     it {
-      is_expected.to validate_uniqueness_of(:title).with_message('must be unique')
+      is_expected.to validate_uniqueness_of(:title).case_insensitive
+                                                   .with_message('must be unique')
     }
 
     it { is_expected.to validate_presence_of(:description) }

spec/models/region_spec.rb

@@ -7,7 +7,8 @@
     it { is_expected.to validate_presence_of(:abbreviation) }
 
     it {
-      is_expected.to validate_uniqueness_of(:abbreviation).with_message('must be unique')
+      is_expected.to validate_uniqueness_of(:abbreviation).case_insensitive
+                                                          .with_message('must be unique')
     }
 
     it { is_expected.to validate_presence_of(:description) }