Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map only identifier and blueprint in get entities for delete stale entities, and aggregate resources by kind #14

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Map only identifier and blueprint in get entities for delete stale entities, and aggregate resources by kind #14

merged 2 commits into from
Jun 8, 2023

Conversation

talsabagport
Copy link
Contributor

@talsabagport talsabagport commented Jun 6, 2023 •
edited
Loading

  • Map only identifier and blueprint in get entities for delete stale entities to avoid failures when there is an issue with other mappings (for properties and relations for example).
  • Aggregate resources by kind for controller, to avoid concurrent map read and map write in K8s SDK when interacting with the same object concurrently.

@talsabagport talsabagport changed the title Map only identifier and blueprint in get entities for delete stale entities Map only identifier and blueprint in get entities for delete stale entities, and aggregate resources by kind Jun 7, 2023
@talsabagport talsabagport merged commit 175181c into main Jun 8, 2023
@talsabagport talsabagport deleted the PORT-3942-k-8-s-exporter-not-skipping-delete-phase-on-error branch June 8, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielsinai danielsinai danielsinai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talsabagport @danielsinai