-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deno: move from std node polyfills to node:
specifier
#771
base: master
Are you sure you want to change the base?
Conversation
same 👍 |
It'd honestly be good to get this merged and resolve the error issue at a later date because of those warnings, could we get this PR reviewed? |
I'm thinking a hard cut in v4 where we just remove the deno polyfill completely if possible? |
As Deno got npm compatibility a while back, I think it might be the right play but this could still get accepted for v3 to avoid headaches |
Yes, the current version on supabase/edge-runtime it's not just a warning, but it triggers an error and become unusable:
While switching to use this PR the error is gone. |
Note that removing tls polyfill cause ssl connections fail to a database with self signed certificate. This breaks cloud services like Supabase as well. The reason for that is the incompatibility of tls socket options in different runtimes. In nodejs, you set |
Hello
I've been using postgres.js in a Deno project for a while but I just noticed how outdated the compatibility really is.
Before this gets accepted though, I'd also like to solve these errors when the connection string is invalid/can't connect. I have no idea if these happen on node but I'd assume not.