Update Dockerfile - remove copy /static build step #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the upstream merge (#245), the deploy action failed. It looks like we need to remove this step from the Dockerfile where the
staticdirectory is copied around.Upstream, the Broad removed this step in July: broadinstitute@89aeb5a
The reason this wasn't caught during the merge is because our Dockerfile is very different from the Dockerfile used in the Broad's seqr deploy. It wasn't clear at the time of the merge that this change needed to be brought across.
Hopefully this resolves the deploy action failure.