Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bamtocram resourcegroup fix #1130

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Bamtocram resourcegroup fix #1130

merged 2 commits into from
Feb 3, 2025

Conversation

EddieLF
Copy link
Contributor

@EddieLF EddieLF commented Feb 3, 2025

Changing the resource group to ".crai" instead of ".cram.crai" had the effect of saving the index files with just the .crai extension. This had downstream effects in Seqr, so the change is being reverted to how it was in the prior commit.

@EddieLF EddieLF requested a review from MattWellie February 3, 2025 02:48
Copy link
Contributor

@MattWellie MattWellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.67%. Comparing base (10c21e6) to head (ebad75b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1130   +/-   ##
=======================================
  Coverage   26.67%   26.67%           
=======================================
  Files           9        9           
  Lines        1732     1732           
=======================================
  Hits          462      462           
  Misses       1270     1270           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EddieLF EddieLF merged commit 7c306ee into main Feb 3, 2025
4 checks passed
@EddieLF EddieLF deleted the bamtocram_resourcegroup_fix branch February 3, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants