Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mallard #826

Merged
merged 1 commit into from
Apr 9, 2021
Merged

mallard #826

merged 1 commit into from
Apr 9, 2021

Conversation

petrelharp
Copy link
Contributor

This will close #822.

@petrelharp petrelharp marked this pull request as draft March 30, 2021 17:32
@petrelharp petrelharp force-pushed the mallard branch 2 times, most recently from 1306b69 to 9cb1afd Compare April 9, 2021 00:04
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #826 (d8700f3) into main (0f6824e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d8700f3 differs from pull request most recent head b0cff18. Consider uploading reports for the commit b0cff18 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #826   +/-   ##
=======================================
  Coverage   99.38%   99.39%           
=======================================
  Files          62       66    +4     
  Lines        2450     2486   +36     
  Branches      285      285           
=======================================
+ Hits         2435     2471   +36     
  Misses          7        7           
  Partials        8        8           
Impacted Files Coverage Δ
stdpopsim/catalog/AnaPla/__init__.py 100.00% <100.00%> (ø)
stdpopsim/catalog/AnaPla/demographic_models.py 100.00% <100.00%> (ø)
stdpopsim/catalog/AnaPla/genome_data.py 100.00% <100.00%> (ø)
stdpopsim/catalog/AnaPla/species.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f6824e...b0cff18. Read the comment docs.

@jeromekelleher
Copy link
Member

Maybe we should split this into 2 PRs @petrelharp, one for the species and one for the demographic model? It'll make it easier to review and keep track of things from a QC perspective.

@jeromekelleher jeromekelleher marked this pull request as ready for review April 9, 2021 15:28
@jeromekelleher
Copy link
Member

Merging, thanks @petrelharp!

@jeromekelleher jeromekelleher merged commit 03626ac into popsim-consortium:main Apr 9, 2021
@petrelharp petrelharp mentioned this pull request Apr 9, 2021
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mallard
2 participants