QCed CanFam

[David-Peede]

Added notes to help with clarifications, but besides that everything looks good!

[David-Peede]

Would someone mind walking me through what went wrong here? I thought I did everything the same as my previous PRs.... I also tried to google the exit code, but was a tad confused on what actually went wrong... Thanks in advance for any guidance!

[grahamgower]

Hey @David-Peede. There are two things going on here.

• There are some long lines at lines 114 and 115. We check for long lines (among other things) with flake8 --max-line-length 89 during the continuous integration checks (https://stdpopsim.readthedocs.io/en/latest/development.html#unit-tests).
• The stdpopsim repository has many changes in it that have occurred since you last pulled or cloned from the repository. So your pull request needs to be rebased against the latest branch (https://stdpopsim.readthedocs.io/en/latest/development.html#rebasing).

[David-Peede]

Thanks again for all your help @grahamgower I hopefully got it right this time!

[PopSim-bot]

📖 Docs for this PR can be previewed here

[codecov]

Codecov Report

Merging #652 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #652   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          33       33           
  Lines        2247     2247           
  Branches      272      272           
=======================================
  Hits         2241     2241           
  Misses          2        2           
  Partials        4        4           

Impacted Files	Coverage Δ
stdpopsim/catalog/CanFam/__init__.py	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a81362...149cf0a. Read the comment docs.

[grahamgower]

Thanks @David-Peede!