-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Canis familiaris to species catalog. #375
Conversation
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
==========================================
+ Coverage 99.48% 99.49% +<.01%
==========================================
Files 14 15 +1
Lines 1164 1179 +15
Branches 120 121 +1
==========================================
+ Hits 1158 1173 +15
Misses 2 2
Partials 4 4
Continue to review full report at Codecov.
|
looks good. just missing the RTD stuff and tests, yeah |
This needs popsim-consortium#375 to unbreak the RTD build.
was the RTD thing with the citations to blame here for the ci error? |
Yep. And as far as I can tell, the unit tests that are missing from this PR would only be like those I'm complaining about in #376. |
just looked at that issue. for now lets stick to including too many unit tests i think and if you agree we can get this one merged |
Ok, I added the unit test file. In the spirit of providing solutions, and not just criticism, I put in an end-to-end test (i.e. test that this runs: |
This is excellent, thanks @grahamgower! It would be nice to add tests for pop size as I discussed in #376, but otherwise LGTM. |
I'm happy to merge here. I'll let @andrewkern push the button in case there's anything he spots. |
looks really good. i like the end-to-end test especially @grahamgower. this might be a good standard to adopt for each species. |
TODO: species specific tests and rtd stuff. Anything else missing?