Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning when using a non-QCed model #499

Closed
grahamgower opened this issue Apr 28, 2020 · 1 comment · Fixed by #525
Closed

Add warning when using a non-QCed model #499

grahamgower opened this issue Apr 28, 2020 · 1 comment · Fixed by #525
Labels
good first issue Good for newcomers
Milestone
Version 0.1.2

Comments

@grahamgower
Copy link
Member

#496 has shown that we really can't trust non-QCed models. So we definitely want a caveat emptor-type warning if a user runs a model before it get's QCed. Related to #304 and #305.
@grahamgower grahamgower changed the title Add CLI warning when using a non-QCed model Add warning when using a non-QCed model Apr 28, 2020
@grahamgower grahamgower added the good first issue Good for newcomers label Apr 28, 2020
@grahamgower grahamgower added this to the Version 0.1.2 milestone Apr 28, 2020
@grahamgower
Copy link
Member Author

We should also have a warning in the catalog docs for non-QCed models. Actually, the developer docs regarding the QC process currently implies: non-QCed models are not connected to the CLI, and don't appear in the catalog documentation. This is clearly not the case. I don't think it's necessary for the non-QCed models to be avoided in the CLI or the catalog docs, but wanted to check in case others disagree.

grahamgower added a commit to grahamgower/stdpopsim that referenced this issue May 10, 2020
@grahamgower
Warn when using a non-QCed model.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
1d4a355 
Closes popsim-consortium#499.
@grahamgower grahamgower mentioned this issue May 10, 2020
Merged
grahamgower added a commit to grahamgower/stdpopsim that referenced this issue May 11, 2020
@grahamgower
Warn when using a non-QCed model.
b9f9643 
Closes popsim-consortium#499.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
Version 0.1.2
Development

Successfully merging a pull request may close this issue.

Warn when using a non-QCed model. grahamgower/stdpopsim
1 participant
@grahamgower