Skip to content

Commit

Permalink
sched/autogroup: Fix sysctl move
Browse files Browse the repository at this point in the history
Ivan reported /proc/sys/kernel/sched_autogroup_enabled went walk-about
and using the noautogroup command line parameter would result in a
boot error message.

Turns out the sysctl move placed the init function wrong.

Fixes: c8eaf6a ("sched: move autogroup sysctls into its own file")
Reported-by: Ivan Kozik <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Tested-by: Ivan Kozik <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
  • Loading branch information
Peter Zijlstra committed May 30, 2022
1 parent 7e28407 commit 82f586f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/sched/autogroup.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ void __init autogroup_init(struct task_struct *init_task)
kref_init(&autogroup_default.kref);
init_rwsem(&autogroup_default.lock);
init_task->signal->autogroup = &autogroup_default;
sched_autogroup_sysctl_init();
}

void autogroup_free(struct task_group *tg)
Expand Down Expand Up @@ -219,7 +220,6 @@ void sched_autogroup_exit(struct signal_struct *sig)
static int __init setup_autogroup(char *str)
{
sysctl_sched_autogroup_enabled = 0;
sched_autogroup_sysctl_init();

return 1;
}
Expand Down

0 comments on commit 82f586f

Please sign in to comment.