HID: intel-ish-hid: ipc: Add check for pci_alloc_irq_vectors

Add a check for the return value of pci_alloc_irq_vectors() and return error if it fails. [[email protected]: reworded changelog based on Srinivas' suggestion] Fixes: 74fbc7d ("HID: intel-ish-hid: add MSI interrupt support") Signed-off-by: Chen Ni <[email protected]> Acked-by: Srinivas Pandruvada <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
pop-os · May 6, 2024 · 6baa452 · 6baa452
1 parent b88ee22
commit 6baa452
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
@@ -173,6 +173,11 @@ static int ish_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 	/* request and enable interrupt */
 	ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
+	if (ret < 0) {
+		dev_err(dev, "ISH: Failed to allocate IRQ vectors\n");
+		return ret;
+	}
+
 	if (!pdev->msi_enabled && !pdev->msix_enabled)
 		irq_flag = IRQF_SHARED;