chore: Update ron to 0.9 #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ron 0.9 has been in the works for years at this point (0.8 the latest stable was tagged in August 2023), but sadly has stalled quite a bit: ron-rs/ron#496
It adds a bunch of really nice features, like support for tagged or untagged enum variants, but more importantly it has a new
RawValuetype (similar toserde_json::RawValue), which allows us to address a few shortcomings like: pop-os/cosmic-settings-daemon#68I say, lets bite the bullet and try the alpha-version of it. It seems remaining issues are only around
#[serde(flatten), which we don't use: https://github.com/search?q=org%3Apop-os%20%23%5Bserde(flatten)%5D&type=code