-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify branches #67
Unify branches #67
Conversation
Requesting an explicit review from @13r0ck to ensure that all required commits from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4c42f32 should be dropped
Package is failing to build for that last commit |
Note to QA: This will be merged on all versions, so it will need more testing than is indicated by the build server. For the purposes of testing, I've created a branch of this |
The build is failing due to an error on the build server, namely:
|
Attempting to build locally on Jammy still gives a different error:
Wasn't this what 4c42f32 was supposed to fix? Or do changes from #64 need to be brought in here? |
I rebased this branch on |
I updated the build branch for the other versions as well |
The new kernelstub build works on a fresh Jammy install
sudo kernelstub -k /boot/vmlinuz-5.18.10-76051810-generic -i /boot/initrd.img-5.18.10-76051810-generic -o "loglevel=0 systemd.show_status=false splash"
sudo kernelstub -a quiet
sudo kernelstub -d quiet |
All tests on Focal are passing. The tests mentioned above pass. I also updated the kernel with no issue switching between kernels at boot, and no issue with using kernelstub to change the default kernel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good!
This PR will unify our separate master branches into a single master for easier management in the future, especially with immutable bases.