Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in pop-boot.postinst #54

Closed
cloudishBenne opened this issue Sep 5, 2021 · 1 comment · Fixed by #55
Closed

Typo in pop-boot.postinst #54

cloudishBenne opened this issue Sep 5, 2021 · 1 comment · Fixed by #55
Assignees
@isantop
Labels
bug Something isn't working

Comments

@cloudishBenne
Copy link

https://github.com/pop-os/kernelstub/blob/master/debian/pop-boot.postinst

Bug in line 5

line 5: DISTRO_DFAULT_KERNEL_OPTIONS=quiet splash loglevel=0
line 10: --options "$DISTRO_DEFAULT_KERNEL_OPTIONS" \

Solution

change line 5 to: DISTRO_DEFAULT_KERNEL_OPTIONS=quiet splash loglevel=0
@isantop isantop self-assigned this Sep 16, 2021
@isantop isantop added the bug Something isn't working label Sep 16, 2021
isantop added a commit that referenced this issue Sep 16, 2021
@isantop
debian: remove pop-boot package
07533f8 
This package was briefly used when we transitioned to kernelstub, however
it should be installed on modern systems as it can cause random loss of
boot options (which, in extreme circumstances, may cause the boot to fail).
We should thus remove this package from the build as every supported version
of Pop_OS uses kernelstub by default (on EFI systems; legacy boot systems are
a non-issue because they won't/can't be transitioned to kernelstub/systemd-boot)

Fixes #54 (by removing the offending file altogether)
@isantop isantop mentioned this issue Sep 16, 2021
Merged
isantop added a commit that referenced this issue Sep 16, 2021
@isantop
debian: remove pop-boot package
0c2137f 
This package was briefly used when we transitioned to kernelstub, however
it should not be installed on modern systems as it can cause random loss of
boot options (which, in extreme circumstances, may cause the boot to fail).
We should thus remove this package from the build as every supported version
of Pop_OS uses kernelstub by default (on EFI systems; legacy boot systems are
a non-issue because they won't/can't be transitioned to kernelstub/systemd-boot)

Fixes #54 (by removing the offending file altogether)
jackpot51 pushed a commit that referenced this issue Sep 17, 2021
@isantop @jackpot51
debian: remove pop-boot package
de5b292 
This package was briefly used when we transitioned to kernelstub, however
it should not be installed on modern systems as it can cause random loss of
boot options (which, in extreme circumstances, may cause the boot to fail).
We should thus remove this package from the build as every supported version
of Pop_OS uses kernelstub by default (on EFI systems; legacy boot systems are
a non-issue because they won't/can't be transitioned to kernelstub/systemd-boot)

Fixes #54 (by removing the offending file altogether)
@cloudishBenne
Copy link
Author

I have a question on this. I assumed this are the standard settings on pop-os, so i installed kernelstub on two other distros to match my pop-os with this command to have a reliable multiboot environment. Is this true? I would appreciate if you could write down the command of the standard installation of pop-os on the Readme.
Another question i have: I have installed an edge kernel for testing and i setup the Boot entries by hand and linked/copied the needed files to the esp. This is all a bit hacky and i have to redo this when i install a new version of the edge kernel. Where should i start to implement proper multi kernel handling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isantop isantop

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

debian: remove pop-boot package pop-os/kernelstub
2 participants
@isantop @cloudishBenne