Fix cosmic workspaces for Jammy jellyfish #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prototype that needs to be refrenced was changed by: https://gitlab.gnome.org/GNOME/gjs/-/commit/e74701596c2ff9880cd39289b9649bb490951091#03566cbfedf849175708a56bfbbc92fe4cd7a28f
13r0ck
force-pushed
the
workspaces-jammy-fix
branch
from
440f2ff to
720733c
Compare
|
Cosmic-workspaces is a fork of https://github.com/RensAlthuis/vertical-overview, so presumably they'd be interested in fixes here (if it doesn't break compatibility with older Gnome Shell releases; not sure if additional conditional logic would be needed). |
|
@ids1024 |
13r0ck
force-pushed
the
workspaces-jammy-fix
branch
from
9782f70 to
3f338a9
Compare
13r0ck
force-pushed
the
workspaces-jammy-fix
branch
from
3f338a9 to
e1f0394
Compare
|
Up-streamed RensAlthuis/vertical-overview#101 |
jacobgkau
approved these changes
Mar 15, 2022
Closed
jackpot51
approved these changes
Mar 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by gnome javascript PR: https://gitlab.gnome.org/GNOME/gjs/-/commit/e74701596c2ff9880cd39289b9649bb490951091#03566cbfedf849175708a56bfbbc92fe4cd7a28f
Caused by gnome-shell PR: https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/5d1d4b56c6a804aec324ca8e97f7e045ce49e958
There are potentially more upstream changes, but that should be the bulk of it.