Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Region & Language page #764

Merged
merged 7 commits into from
Nov 11, 2024
Merged

feat: add Region & Language page #764

merged 7 commits into from
Nov 11, 2024

Conversation

mmstick
Copy link
Member

@mmstick mmstick commented Nov 6, 2024

Closes #12

@mmstick mmstick marked this pull request as ready for review November 7, 2024 16:06
@git-f0x
Copy link
Contributor

git-f0x commented Nov 7, 2024

Might be a bit of an edge case, but I can't seem to set Serbian (Latin) as a language (it defaults to Cyrillic).
I think GNOME Settings on 22.04 provided such an option (maybe lichen doesn't support that yet?).

@git-f0x
Copy link
Contributor

git-f0x commented Nov 11, 2024

Sliders are also slightly broken for some reason. Not sure what libcosmic (or possibly iced) commit caused that.
screenshot-2024-11-11-14-58-17

@mmstick
Copy link
Member Author

mmstick commented Nov 11, 2024

Yeah I've been looking into a similar issue with FlexRow's child widgets having the same width as the FlexRow widget.

@git-f0x
Copy link
Contributor

git-f0x commented Nov 11, 2024

The only somewhat notable change that could affect that between updates is the Iced update (which includes pop-os/iced@51ad918 and the commit after it).

@wash2
Copy link
Contributor

wash2 commented Nov 11, 2024

Not sure why this would only now become a problem, but https://github.com/pop-os/libcosmic/blob/3dcc47d6a7d14423fbd372a0a5ce3c7c9581dd75/src/widget/flex_row/layout.rs#L66 seems to pass the limits of the flex row to each child widget. I guess it is recalculated afterward, so that may not be responsible.

@mmstick
Copy link
Member Author

mmstick commented Nov 11, 2024

Narrowed it down to a change in libcosmic

@git-f0x
Copy link
Contributor

git-f0x commented Nov 11, 2024

Oh, I caused it. Sorry!
It previously wasn't in a container (before the 32px min height commit), so I thought it was unnecessary after the rebase changes.

@mmstick mmstick merged commit 8a20cbc into master Nov 11, 2024
3 checks passed
@mmstick mmstick deleted the region branch November 11, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings > Region and Language
3 participants