Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add arm64 build support #2344
feat: add arm64 build support #2344
Changes from 30 commits
9f9e3c8
a6487f9
775fdfd
3e2f48b
d8a54ae
abacf3e
7cbcf85
f2fd85d
3a16bbc
34c3b53
4c480d7
d3fe880
e1ab289
f1d4222
28abf87
10cbf70
28f30ee
ebd3e16
de0b41b
7633529
db754b9
18fc416
a4bcd9c
ce97957
b465138
26cddc8
afc54b6
60a5049
eb4b21b
ddbabc7
122898a
bb3dbff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds
arm64
suffix to the NSIS file name. Butelectron-builder
also creates alatest.yml
to use withelectron-updater
. The name islatest.yml
for bothx64
andarm64
so they end up overwriting each other. Any solution?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I managed to patch this. You can apply this patch to poi as well: https://github.com/webcatalog/webcatalog-app/pull/1253/files