-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macOS releases via Homebrew #74
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanTAllen
added
changelog - added
Automatically add "Added" CHANGELOG entry on merge
do not merge
This PR should not be merged at this time
labels
Dec 19, 2019
SeanTAllen
force-pushed
the
install-macos
branch
from
December 19, 2019 17:41
4f2f06a
to
8d16787
Compare
cquinn
reviewed
Dec 19, 2019
RELEASE_PROCESS.md
Outdated
@@ -24,7 +24,7 @@ git push origin release-0.3.1 | |||
|
|||
## If something goes wrong | |||
|
|||
The release process can be restarted at various points in it's lifecycle by pushing specially crafted tags. | |||
The release process can be restarted at various points in it's life-cycle by pushing specially crafted tags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're in here: it's
=> its
And lifecycle
is at least as valid as life-cycle
.
cquinn
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions, but good overall.
SeanTAllen
force-pushed
the
install-macos
branch
from
December 19, 2019 18:08
8d16787
to
b14928e
Compare
This shouldn't be merged until corral is added to homebrew. There is currently a PR open to add it: Homebrew/homebrew-core#48075
SeanTAllen
force-pushed
the
install-macos
branch
from
December 20, 2019 20:53
b14928e
to
0666cb1
Compare
Corral is now in homebrew. |
SeanTAllen
changed the title
Add macOS release via Homebrew to the release process
Add macOS releases via Homebrew
Dec 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't be merged until corral is added to homebrew.
There is currently a PR open to add it:
Homebrew/homebrew-core#48075