Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS releases via Homebrew #74

Merged
merged 1 commit into from
Dec 22, 2019
Merged

Add macOS releases via Homebrew #74

merged 1 commit into from
Dec 22, 2019

Conversation

SeanTAllen
Copy link
Member

This shouldn't be merged until corral is added to homebrew.
There is currently a PR open to add it:

Homebrew/homebrew-core#48075

@SeanTAllen SeanTAllen added changelog - added Automatically add "Added" CHANGELOG entry on merge do not merge This PR should not be merged at this time labels Dec 19, 2019
@SeanTAllen SeanTAllen requested a review from cquinn December 19, 2019 17:41
@@ -24,7 +24,7 @@ git push origin release-0.3.1

## If something goes wrong

The release process can be restarted at various points in it's lifecycle by pushing specially crafted tags.
The release process can be restarted at various points in it's life-cycle by pushing specially crafted tags.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're in here: it's => its
And lifecycle is at least as valid as life-cycle.

Copy link
Contributor

@cquinn cquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, but good overall.

This shouldn't be merged until corral is added to homebrew.
There is currently a PR open to add it:

Homebrew/homebrew-core#48075
@SeanTAllen
Copy link
Member Author

Corral is now in homebrew.

@SeanTAllen SeanTAllen removed the do not merge This PR should not be merged at this time label Dec 22, 2019
@SeanTAllen SeanTAllen changed the title Add macOS release via Homebrew to the release process Add macOS releases via Homebrew Dec 22, 2019
@SeanTAllen SeanTAllen merged commit 44eb912 into master Dec 22, 2019
@SeanTAllen SeanTAllen deleted the install-macos branch December 22, 2019 15:18
github-actions bot pushed a commit that referenced this pull request Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - added Automatically add "Added" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants