Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix corral run should work if there is no corral.json #57

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Fix corral run should work if there is no corral.json #57

merged 1 commit into from
Nov 25, 2019

Conversation

cquinn
Copy link
Contributor

@cquinn cquinn commented Nov 24, 2019

Run command no longer requires a corral.json bundle file.
Removed extraneous envs.

Fixes #22

@cquinn cquinn added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Nov 24, 2019
@SeanTAllen
Copy link
Member

Is there a test or tests we can add to avoid a regression on this?

@cquinn
Copy link
Contributor Author

cquinn commented Nov 24, 2019

I will tackle issue #10 today and add an integration test harness and some tests. I'll include a test for this and #56 at that point. Are you OK with merging these two small fixes before the general testing improvements?

@SeanTAllen
Copy link
Member

Sounds good @cquinn.

@SeanTAllen SeanTAllen changed the title Fix corral run should work if there is no bundle.json Fix corral run should work if there is no corral.json Nov 25, 2019
@SeanTAllen SeanTAllen merged commit d7d9980 into ponylang:master Nov 25, 2019
github-actions bot pushed a commit that referenced this pull request Nov 25, 2019
@ponylang-main
Update CHANGELOG for PR #57 [skip ci]
864ed64
@cquinn cquinn deleted the corral-22-run_no_bundle branch December 2, 2019 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Theodus Theodus Awaiting requested review from Theodus

@rkallos rkallos Awaiting requested review from rkallos

@SeanTAllen SeanTAllen Awaiting requested review from SeanTAllen

Assignees
No one assigned
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

corral run should work if there is no bundle.json
2 participants
@cquinn @SeanTAllen