Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bundle.json to corral.json #52

Merged
merged 1 commit into from
Nov 16, 2019
Merged

Rename bundle.json to corral.json #52

merged 1 commit into from
Nov 16, 2019

Conversation

SeanTAllen
Copy link
Member

Currently, the transition path from stable to corral is difficult.
Both use the name bundle.json but they have a different format.
Per issue #17, we have decided to rename corral's dependency file
from bundle.json to corral.json.

Closes #17

Currently, the transition path from stable to corral is difficult.
Both use the name bundle.json but they have a different format.
Per issue #17, we have decided to rename corral's dependency file
from bundle.json to corral.json.

Closes #17
@SeanTAllen
Copy link
Member Author

I left the term "Bundle" in place. That seems reasonable.

@cquinn I also didn't change bundle.json to corral.json in package_dependency_management.md as I believe all references there are in relation to stable not corral. Can you verify that it is correct?

@SeanTAllen SeanTAllen added the triggers release Major issue that when fixed, results in an "emergency" release label Nov 16, 2019
Copy link
Contributor

@cquinn cquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cquinn
Copy link
Contributor

cquinn commented Nov 16, 2019

And, yes, the bundle.json mentions in package_dependency_management.md all refer to stable.

@SeanTAllen SeanTAllen merged commit b092857 into master Nov 16, 2019
@SeanTAllen SeanTAllen deleted the 17 branch November 16, 2019 16:29
SeanTAllen added a commit that referenced this pull request Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triggers release Major issue that when fixed, results in an "emergency" release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition from stable is currently problematic
2 participants