Fixes method access checks (#669)

* use .some to find table access type * chore: changeset Co-authored-by: mendesfabio <[email protected]>
ponder-sh · Feb 29, 2024 · 41c72ad · 41c72ad
1 parent 46816a0
commit 41c72ad
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/.changeset/spicy-otters-scream.md b/.changeset/spicy-otters-scream.md
@@ -0,0 +1,5 @@
+---
+"@ponder/core": patch
+---
+
+Fixed indexing service event ordering bug.
diff --git a/packages/core/src/indexing/service.ts b/packages/core/src/indexing/service.ts
@@ -905,7 +905,9 @@ export class IndexingService extends Emittery<IndexingEvents> {
 
         // All tables that this indexing function key reads
         const tableReads = this.tableAccess[indexingFunctionKey]
-          ?.filter((t) => storeMethodAccess[t.storeMethod][0] === "read")
+          ?.filter((t) =>
+            storeMethodAccess[t.storeMethod].some((s) => s === "read"),
+          )
           .map((t) => t.tableName);
 
         // All indexing function keys that write to a table in `tableReads`
@@ -917,7 +919,7 @@ export class IndexingService extends Emittery<IndexingEvents> {
           ] ?? []) {
             if (
               !parentIndexingFunctionKey.includes(":setup") &&
-              storeMethodAccess[storeMethod][1] === "write" &&
+              storeMethodAccess[storeMethod].some((s) => s === "write") &&
               tableReads.includes(tableName) &&
               parentIndexingFunctionKey !== indexingFunctionKey
             ) {
@@ -928,7 +930,7 @@ export class IndexingService extends Emittery<IndexingEvents> {
 
         const isSelfDependent = this.tableAccess[indexingFunctionKey]?.some(
           (t) =>
-            storeMethodAccess[t.storeMethod][1] === "write" &&
+            storeMethodAccess[t.storeMethod].some((s) => s === "write") &&
             tableReads.includes(t.tableName),
         );