sdk-go/ci: update lint

.github/workflows/lint.yaml

@@ -17,9 +17,9 @@ jobs:
 
       - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
         with:
-          go-version: 1.21.x
+          go-version: 1.23.x
           cache: false
 
       - uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86
         with:
-          version: v1.55
+          version: v1.60.1

.golangci.yml

@@ -1,14 +1,15 @@
-run:
-  deadline: 20m
-
 linters-settings:
   dupl:
     threshold: 100
   funlen:
     lines: 100
     statements: 50
   gci:
-    local-prefixes: github.com/pomerium/pomerium
+    custom-order: true
+    sections:
+      - standard
+      - default
+      - prefix(github.com/pomerium)
   goconst:
     min-len: 2
     min-occurrences: 2
@@ -29,18 +30,11 @@ linters-settings:
     min-complexity: 15
   goimports:
     local-prefixes: github.com/pomerium/pomerium
-  golint:
-    min-confidence: 0
-  govet:
-    check-shadowing: false
   lll:
     line-length: 160
-  maligned:
-    suggest-new: true
   misspell:
     locale: US
   nolintlint:
-    allow-leading-space: true # don't require machine-readable nolint directives (i.e. with no leading space)
     allow-unused: false # report any unused nolint directives
     require-explanation: false # don't require an explanation for nolint directives
     require-specific: false # don't require nolint directives to be specific about which linter is being skipped
@@ -149,8 +143,3 @@ issues:
       text: "Potential hardcoded credentials"
       linters:
         - gosec
-
-# golangci.com configuration
-# https://github.com/golangci/golangci/wiki/Configuration
-service:
-  golangci-lint-version: 1.34.x # use the fixed version to not introduce new linters unexpectedly

.tool-versions

@@ -1 +1 @@
-golang 1.21.3
+golang 1.23.0

Makefile

@@ -6,7 +6,6 @@ PKG := github.com/pomerium/$(NAME)
 
 BUILDDIR := ${PREFIX}/dist
 BINDIR := ${PREFIX}/bin
-GOLANGCI_VERSION = v1.47.2
 
 
 .PHONY: all

jwks_test.go

@@ -23,7 +23,7 @@ func TestFetchJSONWebKeySet(t *testing.T) {
 	ctx, clearTimeout := context.WithTimeout(context.Background(), time.Second*10)
 	t.Cleanup(clearTimeout)
 
-	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 		io.WriteString(w, `{
 			"keys": [
 			  {

sdk_test.go

@@ -51,7 +51,7 @@ func TestVerifier_GetIdentity(t *testing.T) {
 		}
 		fmt.Fprint(w, a.Email)
 	})
-	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 		b, err := json.Marshal(jwks)
 		assert.NoError(t, err)
 		fmt.Fprint(w, string(b))