Support for empty host in ingress rules (#941) #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kralicky
requested review from
calebdoxsey,
kenjenkins and
wasaga
and removed request for
a team and
kenjenkins
wasaga
approved these changes
Apr 30, 2024
calebdoxsey
reviewed
May 1, 2024
kralicky
force-pushed
the
kralicky/ingress-rule-empty-host
branch
from
62e17fd to
555c44e
Compare
This adds support for empty host values in ingress rules, which act as wildcards and will match any hostname. A special annotation is required to enable this feature, so as to prevent unexpected behavior if the host name is unintentionally omitted.
kralicky
force-pushed
the
kralicky/ingress-rule-empty-host
branch
from
555c44e to
37ffe3f
Compare
kralicky
force-pushed
the
kralicky/ingress-rule-empty-host
branch
from
37ffe3f to
da20e5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for empty host values in ingress rules, which act as wildcards and will match any hostname (or IP address).
There are many cases where an ingress configured this way can cause destructive or unintended behavior. Because it is very easy to (perhaps mistakenly) omit the host field in an ingress rule, the special annotation
ingress.pomerium.io/subtle_allow_empty_host: "true"must be added to any ingress object containing rules with empty host fields.Related issues
Closes #941
Checklist
improvement/bug/ etc)