assigning svc CLuster IP when svc is a NodePort #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm not sure this is an allowed behaviour, please see kubernetes/kubernetes#119700 |
|
hey @wasaga, thanks for your time, so I inspired the implementation from nginx-ingress code because we were wondering why it was working for inrgess-nginx and not for pomerium |
wasaga
reviewed
Feb 11, 2025
Comment on lines
+146
to
+154
| if len(svc.Status.LoadBalancer.Ingress) > 0 { | ||
| ingress.Status.LoadBalancer.Ingress = svcLoadBalancerStatusToIngress(svc.Status.LoadBalancer.Ingress) | ||
| } else if svc.Spec.Type == corev1.ServiceTypeNodePort { | ||
| // Assign ClusterIP for NodePort service | ||
| if svc.Spec.ClusterIP != "" { | ||
| ingress.Status.LoadBalancer.Ingress = append(ingress.Status.LoadBalancer.Ingress, networkingv1.IngressLoadBalancerIngress{ | ||
| IP: svc.Spec.ClusterIP, | ||
| }) | ||
| } |
There was a problem hiding this comment.
- probably this logic should live in
svcLoadBalancerStatusToIngress - the
ifcondition as written would not update the status if we transition from > 0 to 0 - please consider adding a unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issues
Checklist
improvement/bug/ etc)