add terraform module #1049
Closed
add terraform module #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasaga
commented
Oct 10, 2024
| source = "git:https://github.com/pomerium/ingress-controller//terraform?ref=v0.28.0" | ||
| } | ||
|
|
||
| resource "kubernetes_manifest" "pomerium_config" { |
There was a problem hiding this comment.
the installation and configuration need be split into separate steps, due to hashicorp/terraform-provider-kubernetes#1367
There was a problem hiding this comment.
Can also use kubectl_manifest instead of kubernetes_manifest, which doesn't have this issue.
resource "kubectl_manifest" "pomerium_config" {
yaml_body = <<YAML
apiVersion: ingress.pomerium.io/v1
kind: Pomerium
metadata:
name: global
spec:
secrets: pomerium-ingress-controller/bootstrap
YAML
}
gaurdro
reviewed
Oct 17, 2024
| run_as_non_root = true | ||
| } | ||
|
|
||
| node_selector = merge(local.default_node_selector, var.node_selector) |
There was a problem hiding this comment.
optional: It's sometimes nicer to do a merge in the local variable.
There was a problem hiding this comment.
do you mean :
node_selector = local.node_selectorand then have
locals {
default_node_selector = {...}
node_selector = merge(local.default_node_selector, var.node_selector)
}There was a problem hiding this comment.
Yes, Or local.computed_node_selector to denote it's not a single-sourced value.
…roxy_node_port_https option for NodePort service type
wasaga
requested review from
calebdoxsey and
wrmedford
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issues
https://github.com/pomerium/internal/issues/1970
Checklist
improvement/bug/ etc)