setup.py: Use gnureadline for all other OS #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
requested changes
Jul 19, 2018
setup.py
Outdated
| elif 'linux' in sysplat or 'freebsd' in sysplat and has_readline: | ||
| pass | ||
| else: | ||
| raise ImportError("readline is not built-in, and no custom package is |
There was a problem hiding this comment.
ImportError doesnt work in setup.py
setup.py
Outdated
|
|
||
| sysplat = str(sys.platform).lower() | ||
| has_readline = sysconfig.get_config_var('HAVE_LIBREADLINE') |
There was a problem hiding this comment.
Rename to have_libreadline to avoid confusion.
setup.py
Outdated
|
|
||
| install_requires = ['setuptools'] | ||
| if 'darwin' in sysplat: | ||
| install_requires += ['gnureadline'] | ||
| if 'win32' in sysplat: | ||
| install_requires += ['pyreadline'] | ||
| elif 'linux' in sysplat or 'freebsd' in sysplat and has_readline: |
There was a problem hiding this comment.
This would break every other OS. Like all the other BSDs. OS checks are inherently bad, unless we know the OS very well and it is known to be broken.
If any OS has libreadline, it is good.
If OS is Windows, use pyreadline.
If anything else (implicitly inc Darwin), add gnureadline as a dependency?
(Read discussion at #1 and at gnureadline issue.)
yzgyyang
force-pushed
the
linux
branch
2 times, most recently
from
f38b0ed to
cecdb1c
Compare
This adds detection for if the readline library is built in, and use gnureadline if that is not the case and not on Windows. Since gnureadline links against a static internal version of the readline library, it could be used for systems where readline support is not built in (except on Windows where we have pyreadline). Closes pombredanne#1
yzgyyang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.py: Use gnureadline for all other OS
This adds detection for if the readline library is built in, and use
gnureadline if that is not the case and not on Windows.
Since gnureadline links against a static internal version of the
readline library, it could be used for systems where readline support
is not built in (except on Windows where we have pyreadline).
Closes #1