Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interrogations regarding diploid phenotypes #2816

Closed
PCarme opened this issue Mar 21, 2024 · 19 comments
Closed

Interrogations regarding diploid phenotypes #2816

PCarme opened this issue Mar 21, 2024 · 19 comments
Assignees

Comments

@PCarme
Copy link

PCarme commented Mar 21, 2024

I just realised that phenotypes annotated on diploid genotypes appear in the "Multi locus genotype annotations and genetic interactions" on the summary page in Canto.
Also, multi-locus phenotypes can't be annotated as genetic interactions with diploid genotypes.
Are these normal ?

@ValWood
Copy link
Member

ValWood commented Mar 21, 2024

I just realised that phenotypes annotated on diploid genotypes appear in the "Multi locus genotype annotations and genetic interactions" on the summary page in Canto.

yes this isn't intuitive, I think there might be a ticket about this that Kim didn't get round to

This might be the ticket, #1932

@ValWood
Copy link
Member

ValWood commented Mar 21, 2024

Also, multi-locus phenotypes can't be annotated as genetic interactions with diploid genotypes.

THe new GI interface is relatively new and we don't annotate many diploid papers, so I don't think this has come up before.

Probably we will open a separate ticket for this and keep a note of any sessions this applies to. It will probably not be high priority for a while because it will only be a small number of sessions but we can increase the priority if we have a lot.
I can't remember ever curating a GI from a diploid!

@ValWood
Copy link
Member

ValWood commented Mar 21, 2024

...even in the old system...

@PCarme
Copy link
Author

PCarme commented Mar 21, 2024

Right, I can imagine this does not happen a lot. Yoshinori's latest community curated paper was ... uncommon ...

@ValWood
Copy link
Member

ValWood commented Mar 22, 2024

@PCarme will describe the diploid genetic interactions from this paper.
@kimrutherford will try to load them manually (with a script)
We will see what happens.

@PCarme
Copy link
Author

PCarme commented Mar 22, 2024

The publication concerned is PMID:38448160, the curation session is f0575bfe108d54e1.
After a second glance at the paper, I only see 2 genetic interactions to be annotated. But the way I have annotated the genotypes, it would be in mutants with more than 2 loci affected, like this one :
image
So, I am guessing that I would first need to change it to only 2 loci. Fortunately, all of the annotations concerned are on genotypes that have two alleles in common (rec8-2A and rec12delta), which I can probably put as background.

@PCarme
Copy link
Author

PCarme commented Mar 25, 2024

The GI to be added are on the two psm3-3A wpl1delta double mutants (in 2 different backgrounds).
image
and
image
Both are a suppression of the "sister kinetochore dissociation in meiotic metaphase I with equational sister chromatid segregation in meiosis I" phenotypes of the psm3-3A mutants (in each background) by wpl1delta.

@kimrutherford
Copy link
Member

Hi @PCarme

What should the interaction type be for the new genetic interactions?

@kimrutherford
Copy link
Member

Diploid-diploid interactions look OK in Canto when I test on my desktop:

image

@PCarme
Copy link
Author

PCarme commented Mar 26, 2024

Interaction type should be "Phenotypic suppression" for both.
In the picture you sent, the phenotype in the "Double mutant phenotype" column is actually the phenotype of the psm3-3A single mutant (with penetrance at 70%)

@kimrutherford
Copy link
Member

Hi Pascal. Does this look correct?

image

image

@PCarme
Copy link
Author

PCarme commented Mar 26, 2024

Yes, that's perfect !

@kimrutherford
Copy link
Member

OK, great. I will check my code again in the morning and then modify the session in the main Canto.

kimrutherford added a commit that referenced this issue Mar 26, 2024
For cases that aren't possible in the interface.

Refs #2816
@kimrutherford
Copy link
Member

I will check my code again in the morning and then modify the session in the main Canto.

That's done now. Let me know if there are any problems.

I've done some testing on my desktop to make sure the website code can handle these interactions. It doesn't look great, but it seems to work. Is this display correct?:

image

kimrutherford added a commit to pombase/pombase-chado-json that referenced this issue Mar 27, 2024
@PCarme
Copy link
Author

PCarme commented Mar 27, 2024

It should rather be psm3 rescued by wpl1. Here it appears inverted.

@kimrutherford
Copy link
Member

No problem. I have swapped the order of genotypes in the interactions in the Canto session.

kimrutherford added a commit that referenced this issue Mar 28, 2024
For cases that aren't possible in the interface.

Refs #2816
@kimrutherford
Copy link
Member

Hi @PCarme

https://www.pombase.org/reference/PMID:38448160

This is how it looks on pombase.org. Is this OK?:

image

@PCarme
Copy link
Author

PCarme commented Apr 4, 2024

That's perfect, thanks Kim !

@kimrutherford
Copy link
Member

Great. I think we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants