Get pending txs too in tx count, hopefully will alleviate some nonce … #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 2cd434f and detected 0 issues on this pull request. View more on Code Climate. |
ceseale
approved these changes
Jan 4, 2019
| @@ -72,8 +72,7 @@ def get_syncing(): | |||
| @chain | |||
| def get_nonce(): | |||
| account = g.chain.w3.toChecksumAddress(g.eth_address) | |||
|
|
|||
| return success(g.chain.w3.eth.getTransactionCount(account)) | |||
| return success(g.chain.w3.eth.getTransactionCount(account, 'pending')) | |||
There was a problem hiding this comment.
I think I've tried using pending like this and it wasn't able to get pending nonces. But, we can try it and see. 🤞 There're are few related issues:
ethereum/go-ethereum#2880
https://ethereum.stackexchange.com/questions/6496/gettransactioncount-with-pending-not-working
There was a problem hiding this comment.
Yeah that's been my experience as well, but I think it's "more correct" this way. Thanks for review
Also gonna try addressing on client-side by tweaking the nonce resync logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…desync issues