Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete deprecated #242

Closed
wants to merge 1 commit into from
Closed

Delete deprecated #242

wants to merge 1 commit into from

Conversation

isovector
Copy link
Member

fuck deprecated code!!

@KingoftheHomeless
Copy link
Collaborator

runFixpoint should go too, right?

@isovector
Copy link
Member Author

Yeah, it should, but the comment scared me about how we need the runIdentity bit afterwards.

@isovector
Copy link
Member Author

Can we write a runPure with that is like the new runM in #239 , except specialised to Identity? Then this thing would just work?

@KingoftheHomeless
Copy link
Collaborator

KingoftheHomeless commented Oct 8, 2019

Yes. We could implement:

runPure :: Sem '[Final Identity] a -> a
runPure = (runIdentity .) $ usingSem $ \u -> case extract u of
  Weaving (WithWeavingToFinal wav) s wv ex ins ->
    ex <$> wav s (runPure . wv) ex

(Omitted Embed Identity since that effect is pointless)

We can even replace run with it, if we want (although that would cause issues for people that write out their effect stack for some reason).

@KingoftheHomeless
Copy link
Collaborator

We had a previous discussion about this when I did the Final rework at polysemy-zoo.
polysemy-research/polysemy-zoo#45 (comment)

@KingoftheHomeless KingoftheHomeless mentioned this pull request Jan 18, 2020
10 tasks
@KingoftheHomeless KingoftheHomeless added this to the v2 milestone Jan 18, 2020
@isovector isovector closed this Nov 26, 2020
@isovector isovector deleted the delete-deprecated branch October 19, 2021 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants