-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WeightToFeeCoefficient type #2296
Add WeightToFeeCoefficient type #2296
Conversation
NB: this is for paritytech/substrate-api-sidecar#50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add the interfaces/support/definitions.ts as an import from interfaces/definitions.ts - the rest are all generated on CI (So running yarn build:interfaces
is optional, but actually really nice to do :))
One more NB...this relates to paritytech/substrate#6076 |
Added to support paritytech/substrate#6076
8230229
to
344ced9
Compare
Thanks for the tips, @jacogr - should be all set now 🙏 Just to confirm, Polkadot JS API will take care of converting snake-case to camel-case, correct? The names of the Substrate types are |
Actually,
TL;DR it is just convenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Just taking a stab at this, I tried running
yarn polkadot-types-from-defs --input ./packages/types/src/interfaces/support/ --package extrinsic
but I get an error that says it can't find/packages/types/src/interfaces/support/default/types.ts
.cc: @amaurymartiny