Asset Hub: remove XCM sufficient asset fee trader #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muharem
commented
Nov 14, 2024
| @@ -263,133 +263,3 @@ fn cannot_create_pool_from_pool_assets() { | |||
| ); | |||
| }); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn pay_xcm_fee_with_some_asset_swapped_for_native() { | |||
There was a problem hiding this comment.
move to the spend file
muharem
commented
Nov 14, 2024
| @@ -276,141 +276,3 @@ fn cannot_create_pool_from_pool_assets() { | |||
| ); | |||
| }); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn pay_xcm_fee_with_some_asset_swapped_for_native() { | |||
There was a problem hiding this comment.
moved to the spend file
muharem
commented
Nov 14, 2024
| @@ -496,66 +496,6 @@ fn receive_reserve_asset_deposited_dot_from_asset_hub_polkadot_fees_paid_by_pool | |||
| ) | |||
| } | |||
|
|
|||
| #[test] | |||
| fn receive_reserve_asset_deposited_dot_from_asset_hub_polkadot_fees_paid_by_sufficient_asset_works() | |||
There was a problem hiding this comment.
similar test where fees paid from the pool exist above
muharem
commented
Nov 14, 2024
| @@ -496,63 +496,6 @@ fn receive_reserve_asset_deposited_ksm_from_asset_hub_kusama_fees_paid_by_pool_s | |||
| ) | |||
| } | |||
|
|
|||
| #[test] | |||
| fn receive_reserve_asset_deposited_ksm_from_asset_hub_kusama_fees_paid_by_sufficient_asset_works() { | |||
There was a problem hiding this comment.
similar test where fees paid from the pool exist above
muharem
changed the title
bkchr
approved these changes
Nov 14, 2024
acatangiu
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Code changes look good (please remove it from testnets as well).
Before merging/releasing this however, we should check to have funded pools for pairs of native and at least the "popular" sufficient assets on Polkadot and Kusama Asset Hubs (DOT, USDT, USDC, WETH, KSM).
Otherwise, we run the risk of breaking currently working usecases/dapps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes sufficient asset trader which used on Asset Hub to pay the XCM fee if there is no pool for a fee asset.
Fixes: #475