Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change max_deciding of the FellowshipAdmin track to 30 #468

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Tomen
Copy link

@Tomen Tomen commented Oct 3, 2024

This PR changes the max number of refs that can be in the deciding state in the FellowshipAdmin track from 10 to 30.

This is a defensive measure to allow a potential submission of 21 rank retention refs for Head Ambassadors to go into simultaneous decision.

Background and Rationale

The OpenGov community is currently discussing updates to the Ambassador Program social contract. One potential path is to begin to make use of the demotionPeriod parameter in the ambassadorCore to introduce a demotion period. This would then force the existing 20 collective members of rank 3 (the highest rank) to submit retention referenda to the OpenGon FellowshipAdmin track. If the track would fill up and not allow sufficient decisions within the demotionPeriod, it could lead to unwanted demotions that are not in the intention of the DAO.

To avoid this situation, this PR raises the limit to 30. This gives room for 21 retention referenda + additional room for any other potential collectives chain related refs.

  • Does not require a CHANGELOG entry

Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could also make sense to add a specific track for the ambassadors, like AmbassadorAdmin or so if it is to be used so regularly.

@wirednkod
Copy link
Contributor

wirednkod commented Oct 3, 2024

I think that @Tomen needs this for the ambassadors collective.
I would suggest all changes to happen based on what @ggwpez proposes.
We should not alter the fellowship collective parameters.
Instead most likely we should create similar functions for the ambassador collectives based on the needs.

What do you think @Tomen ?

@Tomen
Copy link
Author

Tomen commented Oct 4, 2024

I agree that it would be better to have a dedicated track. But right now, as it is written in the code, the Fellowship admin track is not exclusive to the Fellowship, but also serves the Ambassador Collective.

There is a potential risk of an operational bottleneck if we don't change this parameter now that could also affect the Fellowship if a Fellowship related ref would be blocked from entering confirmation because the track is full of Ambassador Collective refs.

I suggest to temporarily raise the limit with this PR until a proper track for the other collective could be established. Then this value could be set down to 10 again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants