-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce System version to RuntimeVersion object #42
Introduce System version to RuntimeVersion object #42
Conversation
a3b9ec7
to
4f77d7c
Compare
4f77d7c
to
9201de9
Compare
Would be really helpful if we can get some more feedback on this one from other team members :) |
b956e67
to
58ce86c
Compare
The |
This is the only use case we have right now. Is the wording confusing or does not meet standards?
I can tag this in the motivation section if it helps |
I just mean that someone who isn't deeply familiar with the trie format and V0 and V1 will not understand the "Motivation" section. But that's not a big deal to me. |
@tomaka what would be the next steps here ? |
Any blockers for moving forward with this? |
"Just" needs some approvals 😄 |
Looks good to me. |
If there's no other comment, I can submit your RFC for voting. |
No other changes from my end. |
/rfc propose |
Hey @tomaka, here is a link you can use to create the referendum aiming to approve this RFC number 0042. Instructions
It is based on commit hash 36b9812834179d8d5109e6ca064a38197d8557d0. The proposed remark text is: |
Voting for this referenda is ongoing. Vote for it [here]https://collectives.polkassembly.io/referenda/70 |
/rfc process 0x10ac786bc859fbaad56ca436bd822a01e0f120d37f85680621700323d35756d9 |
Unable to find the referendum confirm event in the given block. |
/rfc process 0x2cd018900d9c915ce8104cc6e37141b663cb46d13aadbff9dbfa038211228789 |
The on-chain referendum has approved the RFC. |
@tomaka Can you explain what is the process next? I would be happy to produce a PR for this RFC |
@vedhavyas feel free to open a pr and link to the RFC in the pr description. Thank you! |
…nsics root `StateVersion` instead of `V0` (#4257) This PR - Renames `RuntimeVersion::state_version` to `system_version` - Uses `Runtime::system_version` to derive extrinsics root `StateVersion` instead of default `StateVersion::V0` This PR should not be breaking any existing chains so long as they use same `RuntimeVersion::state_version` for `Runtime::system_version` Using `RuntimeVersion::system_version = 2` will make the extrinsics root to use `StateVersion::V1` instead of `V0` RFC for this change - polkadot-fellows/RFCs#42 --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Koute <[email protected]> Co-authored-by: Nazar Mokrynskyi <[email protected]>
@vedhavyas, do you have an update on the status of this RFC? |
Was implemented [here[(https://github.com/paritytech/polkadot-sdk/pull/4257). |
…nsics root `StateVersion` instead of `V0` (paritytech#4257) This PR - Renames `RuntimeVersion::state_version` to `system_version` - Uses `Runtime::system_version` to derive extrinsics root `StateVersion` instead of default `StateVersion::V0` This PR should not be breaking any existing chains so long as they use same `RuntimeVersion::state_version` for `Runtime::system_version` Using `RuntimeVersion::system_version = 2` will make the extrinsics root to use `StateVersion::V1` instead of `V0` RFC for this change - polkadot-fellows/RFCs#42 --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Koute <[email protected]> Co-authored-by: Nazar Mokrynskyi <[email protected]> (cherry picked from commit 9930d21)
This RFC proposes adding
system_version
and removestate_version
fromRuntimeVersion
object. This makes it possible to useStateVersion::V1
for both Storage and Extrinsic root derivations