Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove frontier offchain db on purge-chain subcommand #404

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Remove frontier offchain db on purge-chain subcommand #404

merged 1 commit into from
Jun 9, 2021

Conversation

tgmichel
Copy link
Contributor

@tgmichel tgmichel commented Jun 9, 2021

Rel #401

@tgmichel tgmichel requested a review from sorpaas as a code owner June 9, 2021 07:58
sorpaas
sorpaas approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine as cmd.run just removes the db, but if we want to be more cautious (like if upstream adds other checks before deleting the db, which when dealing with frontier db we don't want), in the future we can also just directly delete the dir.

@sorpaas sorpaas merged commit a13d76d into polkadot-evm:master Jun 9, 2021
@4meta5 4meta5 deleted the tgm-purge-offchain-db branch August 10, 2021 02:16
abhijeetbhagat pushed a commit to web3labs/frontier that referenced this pull request Jan 11, 2023
@tgmichel
Remove frontier offchain db on purge-chain subcommand (polkadot-evm…
58724a9 
…#404)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorpaas sorpaas sorpaas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgmichel @sorpaas