Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add txpool RPC and impl new_pending_transaction_filter #1073

Merged
merged 18 commits into from
Jun 25, 2023

Conversation

boundless-forest
Copy link
Collaborator

@boundless-forest boundless-forest commented Jun 7, 2023

See moonbeam-foundation/moonbeam#2325.

The txpool rpc interface is quite helpful for the browser. This pr adds the txpool moonbeam rpc implementation(thanks for the excellent work). Based on the moonbeam rpc interface, I implemented the new_pending_transaction_filter.

@koushiro
Copy link
Collaborator

koushiro commented Jun 7, 2023

the txpool RPCs should be hidden behind a feature, because they are client-specific features.

client/rpc/src/txpool.rs Outdated Show resolved Hide resolved
client/rpc/src/txpool.rs Outdated Show resolved Hide resolved
primitives/rpc/src/lib.rs Outdated Show resolved Hide resolved
template/node/Cargo.toml Outdated Show resolved Hide resolved
@boundless-forest boundless-forest marked this pull request as ready for review June 8, 2023 11:41
@boundless-forest boundless-forest requested a review from sorpaas as a code owner June 8, 2023 11:41
@boundless-forest boundless-forest marked this pull request as draft June 8, 2023 13:33
@boundless-forest boundless-forest marked this pull request as ready for review June 9, 2023 03:26
@boundless-forest
Copy link
Collaborator Author

@sorpaas Please take a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants