Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure user is authorized to send message. #14

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Ensure user is authorized to send message. #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/server/api/schema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { organizationCache } from '../models/cacheable_queries/organization'

import { gzip, log, makeTree } from '../../lib'
import { applyScript } from '../../lib/scripts'
import { hasRole } from '../../lib/permissions'
import { assignTexters, exportCampaign, loadContactsFromDataWarehouse, uploadContacts } from '../../workers/jobs'
import {
Assignment,
Expand Down Expand Up @@ -873,7 +874,7 @@ const rootMutations = {

return []
},
sendMessage: async (_, { message, campaignContactId }, { loaders }) => {
sendMessage: async (_, { message, campaignContactId }, { user, loaders }) => {
const contact = await loaders.campaignContact.load(campaignContactId)
const campaign = await loaders.campaign.load(contact.campaign_id)
if (contact.assignment_id !== parseInt(message.assignmentId) || campaign.is_archived) {
Expand All @@ -882,6 +883,23 @@ const rootMutations = {
message: 'Your assignment has changed'
})
}

const assignment = await loaders.assignment.load(contact.assignment_id)
const currentRoles = (await r
.knex('user_organization')
.where({
user_id: user.id,
organization_id: campaign.organization_id,
})
.select('role')).map(res => res.role)
const isAdmin = hasRole('SUPERVOLUNTEER', currentRoles)
if (!isAdmin && assignment.user_id !== user.id) {
throw new GraphQLError({
status: 403,
message: 'You are not authorized to send a message for this assignment!'
})
}

const organization = await r
.table('campaign')
.get(contact.campaign_id)
Expand Down