Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knex-ify MySQL Migrations #139

Merged
merged 4 commits into from
Apr 26, 2019
Merged

Knex-ify MySQL Migrations #139

merged 4 commits into from
Apr 26, 2019

Conversation

bchrobot
Copy link
Member

@bchrobot bchrobot commented Apr 25, 2019 •
edited
Loading

Skipping:

  • 001-create_mysql.sql -- redundant with 20190207220000_init_db.js
  • 002-mysql-utf8mb4.sql -- encoding should be set in database configuration going forward
  • 006-make-org-features-text.sql -- features is set to text in 20190207220000_init_db.js

@bchrobot bchrobot requested a review from ben-pr-p April 25, 2019 19:36
@bchrobot bchrobot marked this pull request as ready for review April 25, 2019 19:56
@ben-pr-p
Copy link
Contributor

Nice!

@bchrobot bchrobot merged commit a2dcda8 into politics-rewired/deploy Apr 26, 2019
@bchrobot bchrobot deleted the politics-rewired/knex-ify-mysql-migrations branch April 26, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-pr-p ben-pr-p ben-pr-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bchrobot @ben-pr-p