-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename internalRuntimeForbidden and make heuristics reliable #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iable without static signature file: - On Java 9 (w/wo Jigsaw) check module system for runtime class (module name starts with "java." or "jdk.") - Invert the package pattern: Only list packages in official Java documentation (java.*, javax.* and few others extracted from Javadocs) - Start to rename the setting: internalRuntimeForbidden -> nonPortableRuntimeForbidden
…emaining stuff will be deprecated soon
…d the real class name)
All is implemented. 'internalRuntimForbidden' is deprecated and users should migrate to bundled signatures instead:
I will merge this now into master. |
uschindler
added a commit
that referenced
this pull request
Dec 29, 2015
…ewrite Rename internalRuntimeForbidden and make heuristics reliable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrite does the following:
The new algorithm is simple:
If a class loaded is from the Java runtime (fixed in #91) and the module is correct, we will do a package name against a whitelist, extracted from Java 8 Javadocs. This will also detect non-portable classes from non-Oracle runtimes correctly. Just everything from the runtime packages (files under java.home or from modules in Java 9 that are part of runtime) is checked for package whitelist, everything else is not documented.
If somebody (like @rmuir in his JAR file tests) only wants to forbid "internal" packages according to security settings, the bundled signatures files can be used.
In this PR I will also remove the special flag "internalRuntimeForbidden" (deprecate and remove later!) and make the heuristics available as bundled signature. The bundled signature just does not exist as file in JAR file, it points to the rewriten heuristics code.