Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bundle 'jdk-reflection' #86

Merged
merged 3 commits into from
Nov 14, 2015
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,7 @@
<bundledsignatures name="jdk-unsafe-${build.java.runtime}"/>
<bundledsignatures name="jdk-deprecated-${build.java.runtime}"/>
<bundledsignatures name="jdk-system-out"/>
<bundledsignatures name="jdk-reflection"/>
</forbiddenapis>
</target>

Expand Down Expand Up @@ -649,4 +650,4 @@
</target>

<target name="jenkins" depends="clean,dist,test,documentation,-stage.snapshots" description="Runs Jenkins Nightly"/>
</project>
</project>
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# (C) Copyright Uwe Schindler (Generics Policeman) and others.
# Parts of this work are licensed to the Apache Software Foundation (ASF)
# under one or more contributor license agreements.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

java.lang.reflect.AccessibleObject#setAccessible(java.lang.reflect.AccessibleObject[], boolean) @ Reflection usage fails with SecurityManagers and likely will not work any more in Java 9
java.lang.reflect.AccessibleObject#setAccessible(boolean) @ Reflection usage fails with SecurityManagers and likely will not work any more in Java 9
java.lang.reflect.Method#invoke(java.lang.Object, java.lang.Object[]) @ Reflection usage fails with SecurityManagers and likely will not work any more in Java 9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said on issue, I would remove this. It is not bad and won't fail with security managers, unless very restructive. But setAccessible() is a no-go.

Binary file added src/test/antunit/OracleReflection.class
Binary file not shown.
42 changes: 42 additions & 0 deletions src/test/antunit/OracleReflection.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
/*
* (C) Copyright Uwe Schindler (Generics Policeman) and others.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

/* The binary class file is packaged together with the source distribution.
*/

import java.lang.reflect.Field;
import java.lang.reflect.Method;
import java.util.*;

class OracleReflection {
static Field test() throws Exception {
Class c = OracleReflection.class;
Field f = c.getDeclaredField("field1");
f.setAccessible(true);

Method m = c.getDeclaredMethod("testMethod");
m.setAccessible(true);
m.invoke(new OracleReflection());

return f;
}

private Integer field1;

private void testMethod() {
// nothing to do here
}
}
31 changes: 31 additions & 0 deletions src/test/antunit/TestOracleReflection.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
* (C) Copyright Uwe Schindler (Generics Policeman) and others.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
-->
<project xmlns:au="antlib:org.apache.ant.antunit">

<target name="testReflection">
<au:expectfailure expectedMessage="Check for forbidden API calls failed, see log">
<forbiddenapis>
<bundledsignatures name="jdk-reflection"/>
<file file="OracleReflection.class"/>
</forbiddenapis>
</au:expectfailure>
<au:assertLogContains level="error" text="java.lang.reflect.AccessibleObject#setAccessible(boolean) [Reflection usage fails with SecurityManagers"/>
<au:assertLogContains level="error" text="java.lang.reflect.Method#invoke(java.lang.Object, java.lang.Object[]) [Reflection usage fails with SecurityManagers"/>
<au:assertLogContains level="error" text=" 3 error(s)"/>
</target>

</project>