Make Checker extendable from outside of the package #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pickypg, I'll look into this! This explains to my why you forked the Checker class. |
|
Based on the discussion in #66, I will close this pull request as won't fix. It was added because of a "bug" in Checker: It used |
uschindler
added a commit
that referenced
this pull request
Sep 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, using
this.getClass()forces the abstract class to get the extension's package to look for resources. This change forces it to useChecker.classso that extension code can work.I was tempted to make the
parseBundledSignaturesfunction non-finalso that extensions could provide their own bundled resources as well, but I do not need that functionality yet.