Add "failOnViolation" setting to optionally fail builds #62
Conversation
Sometimes it is desired to let a build succeed, even if violations have been found. The "failOnViolation" setting for the Ant task and the Maven Mojo enables the user to let their builds succeed even if violations have been found by the forbidden APIs checker.
|
Hi, Many thanks, |
|
We can maybe also add a "user property" for Maven (like PMD, Findbugs, Checkstyle). This is just a change in the annotation, so we can add this later. The user property is like -Dforbiddenapis.skip to override checks. This can be used e.g. while development to add System.out printlns for debugging, but forbiddenapis prevents you from running tests. So developer can quickly override, still showing the bugs (with skip its disabled completely) |
|
@uschindler Good idea! I've added the system property "forbiddenapis.failOnViolation" (similar to "forbiddenapis.skip") to override the setting in Maven builds. |
Add "failOnViolation" setting to optionally fail builds
|
Thanks @joschi ! |
Sometimes it is desired to let a build succeed, even if violations have been found (e. g. for a gradual roll-out of the forbidden-apis checker in builds).
The "failOnViolation" setting for the Ant task and the Maven Mojo enables the user to let their builds succeed even if violations have been found by the forbidden APIs checker.
This functionality is also provided by other broadly used static code analyzer plugins, like PMD, Checkstyle, and FindBugs.