Fix #168: Commons-IO signatures fails to resolve in commons-io v2.7 #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as there was an incompatible change; This also adds signatures for version 2.7. TODO: Scan for other API differences (new methods) in 2.7 vs. 2.6
Closed
…ematic method is affected
Closed
uschindler
added a commit
that referenced
this pull request
Jun 3, 2020
Commons-IO signatures fails to resolve in commons-io v2.7, as there was an incompatible change; This also adds signatures for version 2.7 (a new abstract class that caused this issue). In a later version of forbiddenapis there will be a more robust fix for this (resolving virtual methods during signatures parsing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is caused by an incompatible change in commons-io 2.7 (
ByteBufferOutputStreamwas refactored to have a new base classAbstractByteBufferOutputStream); This also adds signatures for version 2.7.