Add support for maven.compiler.release/testRelease #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the `maven.compiler.release` and `maven.compiler.testRelease` properties which can be used to since Java 9 to provide the `--release` argument for the Java compiler. The release version is being used over the target version if it was defined, otherwise the target version is being used. * https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#release * https://maven.apache.org/plugins/maven-compiler-plugin/testCompile-mojo.html#testRelease * https://docs.oracle.com/javase/9/tools/javac.htm#GUID-AEEC9F07-CB49-4E96-8BC7-BCC2C7F725C9__GUID-D343F6B4-3FDD-43A8-AD24-43DD70214471
|
Hi @joschi |
|
Hi, Of course this must also be added to Gradle and possibly Ant. Maybe the logic to handle both properties and possible differences should be moved to the Checker / Signatures class itsself. Nevertheless I will target this for version 3.1. Many thanks! |
|
Thanks @joschi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the
maven.compiler.releaseandmaven.compiler.testReleaseproperties which can be used to since Java 9 to provide the--releaseargument for the Java compiler.The release version (
releaseVersion,testReleaseVersion) is being used over the target version (targetVersion,testTargetVersion) if it was defined, otherwise the target version is being used.