Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/116: Compile the Groovy script only once when loading the plugin class #117

Merged
merged 3 commits into from
Jan 31, 2017
Merged

Issues/116: Compile the Groovy script only once when loading the plugin class #117

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fc0a16
Compile and run the script only once.
uschindler Jan 31, 2017
8caa319
Remove obsolete import
uschindler Jan 31, 2017
e43b6a9
Move script compilation to static initializer
uschindler Jan 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions src/main/java/de/thetaphi/forbiddenapis/gradle/ForbiddenApisPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,11 @@
import groovy.util.DelegatingScript;

import java.net.URL;
import java.util.Collections;

import org.codehaus.groovy.control.CompilerConfiguration;
import org.codehaus.groovy.control.customizers.ImportCustomizer;
import org.gradle.api.Plugin;
import org.gradle.api.Project;
import org.gradle.api.plugins.PluginInstantiationException;

/**
* Forbiddenapis Gradle Plugin (requires at least Gradle 2.3)
Expand All @@ -45,22 +43,29 @@ public class ForbiddenApisPlugin implements Plugin<Project> {
/** Name of the extension to define defaults for all tasks of this module. */
public static final String FORBIDDEN_APIS_EXTENSION_NAME = "forbiddenApis";

@Override
public void apply(final Project project) {
private static final DelegatingScript compiledScript;
static {
final ImportCustomizer importCustomizer = new ImportCustomizer().addStarImports(ForbiddenApisPlugin.class.getPackage().getName());
final CompilerConfiguration configuration = new CompilerConfiguration().addCompilationCustomizers(importCustomizer);
configuration.setScriptBaseClass(DelegatingScript.class.getName());
configuration.setSourceEncoding("UTF-8");
final Binding binding = new Binding(Collections.singletonMap("project", project));
final GroovyShell shell = new GroovyShell(ForbiddenApisPlugin.class.getClassLoader(), binding, configuration);
final GroovyShell shell = new GroovyShell(ForbiddenApisPlugin.class.getClassLoader(), new Binding(), configuration);
final URL scriptUrl = ForbiddenApisPlugin.class.getResource(PLUGIN_INIT_SCRIPT);
if (scriptUrl == null) {
throw new PluginInstantiationException("Cannot find resource with script: " + PLUGIN_INIT_SCRIPT);
throw new RuntimeException("Cannot find resource with script: " + PLUGIN_INIT_SCRIPT);
}
final GroovyCodeSource csrc = new GroovyCodeSource(scriptUrl);
final DelegatingScript script = (DelegatingScript) shell.parse(csrc);
script.setDelegate(this);
script.run();
compiledScript = (DelegatingScript) shell.parse(csrc);
}

@Override
public void apply(Project project) {
synchronized(compiledScript) {
compiledScript.setDelegate(this);
compiledScript.setProperty("project", project);
compiledScript.run();
compiledScript.setProperty("project", null); // free resources
}
}

}