Add support for signature polymorphic methods #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for detecting signature polymorphic methods (like
MethodHandle.invoke).The code detects those methods while populating the ClassSignature class (using the Java VM spec). The method names are recorded in a set per class.
The VM spec says:
Type.getMethodDescriptor(Type.getType(Object.class), Type.getType(Object[].class));ACC_VARARGSandACC_NATIVEjava.lang.invoke(this is a slight change to spec, to also catch varhandles -> asked on OpenJDK ML)On forbidden checks it looks up every method name in this set, and if it exists, it replaces the signature by the polymorphic one for the lookup.