Regression: forbidden-apis 1.5 fails on non-runtime annotations (e.g. java.lang.Synthetic) which are not in classpath

[GoogleCodeExporter]

Simon Willnauer tried to use forbidden 1.5 with ElasticSearch. Sometimes the 
compiler generates "virtual" annotations (java.lang.Synthetic) or annotations 
that are not visible at runtime. Those annotations should not be checked, 
because they might not exist on classpath (e.g. Guava's @NotNull).

This has to be fixed and 1.5.1 needs to be released ASAP.

Original issue reported on code.google.com by uwe.h.schindler on 17 Apr 2014 at 1:02

[GoogleCodeExporter]

Original comment by uwe.h.schindler on 17 Apr 2014 at 1:03

• Added labels: Priority-Critical
• Removed labels: Priority-Medium

[GoogleCodeExporter]

As a quick fix, we should ignore all RetentionPolicy.CLASS annotations... It 
also makes not much sense to look at those.

This would limit Forbidden APIS to only check for RetentionPolicy.RUNTIME 
annotations.

Original comment by uwe.h.schindler on 17 Apr 2014 at 1:17

[GoogleCodeExporter]

Patch that disables non-runtime visible annotations.

Original comment by uwe.h.schindler on 17 Apr 2014 at 1:25

Attachments:

• issue27.patch

[GoogleCodeExporter]

this is a good approach. For a build, i'd rather it be totally consistent here 
with this simple fix for now.

Original comment by [email protected] on 17 Apr 2014 at 1:59

[GoogleCodeExporter]

A good fix that inspects RetentionPolicy.CLASS annotations, which ignores 
automatically non-lookup-able annotations needs more work, because you have to 
pass the type down through checkDescriptor, which is not only used for 
Annotations. So its needs more refactoring.

I think, Iwill delay this for version 1.6 of forbidden as a new "feature".

Original comment by uwe.h.schindler on 17 Apr 2014 at 2:05

[GoogleCodeExporter]

Original comment by uwe.h.schindler on 17 Apr 2014 at 2:06

• Changed title: Regression: forbidden-apis 1.5 fails on non-runtime annotations (e.g. java.lang.Synthetic) which are not in classpath

[GoogleCodeExporter]

Improved patch with better reporting for line-number less code parts.

This also adds a test class that had the problem with java.lang.Synthetic:
The ctor of the non-static inner class gets an additional parameter to pass in 
the outer class' instance to have access to OuterClass.this. This parameter 
gets the magic annotation if there are other annotated parameters.

Original comment by uwe.h.schindler on 17 Apr 2014 at 6:55

Attachments:

• issue27.patch

[GoogleCodeExporter]

Committed to trunk, will backport now.

Original comment by uwe.h.schindler on 17 Apr 2014 at 8:38

• Changed state: Committed

[GoogleCodeExporter]

Backported to 1.5 branch and released hotfix.

Original comment by uwe.h.schindler on 17 Apr 2014 at 9:08

• Changed state: Fixed